[v3.0.0] Deprecate SQL Delete statement #3337
Open
+1
−517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
deprecate-delete-statement
branch
from
ee5e40a to
288bc31
Compare
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
noCharger
previously approved these changes
Feb 21, 2025
integ-test/src/test/java/org/opensearch/sql/legacy/ExplainIT.java
Outdated
Show resolved
Hide resolved
legacy/src/main/java/org/opensearch/sql/legacy/query/OpenSearchActionFactory.java
Outdated
Show resolved
Hide resolved
I didn't find earlier. Let me do another pass. Or you mean we should add some test for this breaking changes? |
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
noCharger
approved these changes
Feb 22, 2025
It's fine if there is no existing bwc test. Also, not sure if we can direct the query to a specific node in a mixed cluster with both new and old nodes. |
penghuo
reviewed
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the SQL
DELETEstatement and the associated plugin settingplugins.sql.delete.enabledfrom the codebase, doctests, and documentation.Note: There are still legacy code related to the
DELETEstatement inherited from NLPChina. Since we've been working on Calcite integration, I am leaving that legacy code untouched for now.Related Issues
Resolves #3281
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.