Add ClickBench IT Suite #3860
Merged
Add ClickBench IT Suite #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
added
testing
Collaborator
|
@noCharger please review it |
LantaoJin
commented
Jul 10, 2025
integ-test/src/test/java/org/opensearch/sql/calcite/clickbench/PPLClickBenchIT.java
Outdated
Show resolved
Hide resolved
LantaoJin
commented
Jul 10, 2025
|
|
||
| @Override | ||
| protected Set<Integer> ignored() { | ||
| return Set.of(29, 41, 43); |
Member
Author
There was a problem hiding this comment.
q29: REGEXP_REPLACE() is not supported.
q41: Failed in Calcite engine, TBD
q43: DATE_TRUNC() is not supported.
Member
Author
There was a problem hiding this comment.
Update: only q29 is ignored.
q29: REGEXP_REPLACE() is not supported.
q41: a bug of Sarg, fixed in latest commit
q43: DATE_TRUNC() is not supported. Using DATE_FORMAT() instead. ref link
LantaoJin
commented
Jul 10, 2025
| @@ -0,0 +1,5 @@ | |||
| source=hits | |||
| | where like(URL, '%google%') and SearchPhrase != '' | |||
| | stats /* min(URL), */ count() as c by SearchPhrase | |||
Member
Author
There was a problem hiding this comment.
Can not push down min aggregation on TEXT field in OpenSearch, commented it out.
LantaoJin
commented
Jul 10, 2025
| @@ -0,0 +1,7 @@ | |||
| // EventDate >= '2013-07-01' should work in v3 | |||
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
commented
Jul 10, 2025
7 tasks
noCharger
reviewed
Jul 11, 2025
noCharger
reviewed
Jul 11, 2025
noCharger
approved these changes
Jul 11, 2025
Collaborator
noCharger
left a comment
noCharger
left a comment
There was a problem hiding this comment.
Thanks for the change.
qianheng-aws
approved these changes
Jul 11, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-3860-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9af1567bbb4b04cafbfd40f460f3c0384b31dc81
# Push it to GitHub
git push --set-upstream origin backport/backport-3860-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Jul 11, 2025
* Add clickbench IT Suite Signed-off-by: Lantao Jin <ltjin@amazon.com> * Add original SQL and fix the bug of Sarg point (q41) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix IT of Sarg related Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix UT Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 9af1567)
penghuo
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #3822
Add ClickBench (https://github.com/ClickHouse/ClickBench) to PPL IT suite.
Only one documentation in clickbench index.
It prints the end2end execution times, on my laptop is:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.