Disable a failed PPL query fallback to v2 by default

docs/user/admin/settings.rst

@@ -749,9 +749,9 @@ plugins.calcite.enabled
 Description
 -----------
 
-This setting is present from 3.0.0-beta. You can enable Calcite as new query optimizer and execution engine to all coming requests.
+You can enable Calcite as new query optimizer and execution engine to all coming requests.
 
-1. The default value is false in 3.0.0-beta.
+1. The default value is false since 3.0.0.
 2. This setting is node scope.
 3. This setting can be updated dynamically.
 
@@ -764,9 +764,9 @@ plugins.calcite.fallback.allowed
 Description
 -----------
 
-This setting is present from 3.0.0-beta. If Calcite is enabled, you can use this setting to decide whether to allow fallback to v2 engine for some queries which are not supported by v3 engine.
+If Calcite is enabled, you can use this setting to decide whether to allow fallback to v2 engine for some queries which are not supported by v3 engine.
 
-1. The default value is true in 3.0.0-beta.
+1. The default value is false since 3.2.0.
 2. This setting is node scope.
 3. This setting can be updated dynamically.
 
@@ -776,9 +776,9 @@ plugins.calcite.pushdown.enabled
 Description
 -----------
 
-This setting is present from 3.0.0-beta. If Calcite is enabled, you can use this setting to decide whether to enable the operator pushdown optimization for v3 engine.
+If Calcite is enabled, you can use this setting to decide whether to enable the operator pushdown optimization for v3 engine.
 
-1. The default value is true in 3.0.0-beta.
+1. The default value is true since 3.0.0.
 2. This setting is node scope.
 3. This setting can be updated dynamically.
 
@@ -788,8 +788,8 @@ plugins.calcite.pushdown.rowcount.estimation.factor
 Description
 -----------
 
-This setting is present from 3.1.0. If Calcite pushdown optimization is enabled, this setting is used to estimate the row count of the query plan. The value is a factor to multiply the row count of the table scan to get the estimated row count.
+If Calcite pushdown optimization is enabled, this setting is used to estimate the row count of the query plan. The value is a factor to multiply the row count of the table scan to get the estimated row count.
 
-1. The default value is 0.9 in 3.1.0.
+1. The default value is 0.9 since 3.1.0.
 2. This setting is node scope.
 3. This setting can be updated dynamically.

integ-test/src/test/java/org/opensearch/sql/calcite/big5/CalcitePPLBig5IT.java

@@ -15,6 +15,5 @@ public class CalcitePPLBig5IT extends PPLBig5IT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/clickbench/CalcitePPLClickBenchIT.java

@@ -15,6 +15,5 @@ public class CalcitePPLClickBenchIT extends PPLClickBenchIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteArrayFunctionIT.java

@@ -20,7 +20,6 @@ public class CalciteArrayFunctionIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
     loadIndex(Index.BANK);
   }
 

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteConvertTZFunctionIT.java

@@ -12,6 +12,5 @@ public class CalciteConvertTZFunctionIT extends ConvertTZFunctionIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteCsvFormatIT.java

@@ -12,6 +12,5 @@ public class CalciteCsvFormatIT extends CsvFormatIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDataTypeIT.java

@@ -12,6 +12,5 @@ public class CalciteDataTypeIT extends DataTypeIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDateTimeComparisonIT.java

@@ -17,6 +17,5 @@ public CalciteDateTimeComparisonIT(String functionCall, String name, Boolean exp
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDateTimeFunctionIT.java

@@ -14,7 +14,6 @@ public class CalciteDateTimeFunctionIT extends DateTimeFunctionIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   // TODO: Remove this when supporting type coercion and casting with Calcite

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDateTimeImplementationIT.java

@@ -12,6 +12,5 @@ public class CalciteDateTimeImplementationIT extends DateTimeImplementationIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDedupCommandIT.java

@@ -13,7 +13,6 @@ public class CalciteDedupCommandIT extends DedupCommandIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteDescribeCommandIT.java

@@ -12,6 +12,5 @@ public class CalciteDescribeCommandIT extends DescribeCommandIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExpandCommandIT.java

@@ -29,7 +29,6 @@ public void init() throws Exception {
     loadIndex(Index.NESTED_SIMPLE);
     loadIndex(Index.ARRAY);
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Test

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java

@@ -18,7 +18,6 @@ public class CalciteExplainIT extends ExplainIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteFieldsCommandIT.java

@@ -12,6 +12,5 @@ public class CalciteFieldsCommandIT extends FieldsCommandIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteFillNullCommandIT.java

@@ -12,6 +12,5 @@ public class CalciteFillNullCommandIT extends FillNullCommandIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteFlattenCommandIT.java

@@ -30,7 +30,6 @@ public void init() throws Exception {
     super.init();
     loadIndex(NESTED_WITHOUT_ARRAYS);
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Test

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteFlattenDocValueIT.java

@@ -12,6 +12,5 @@ public class CalciteFlattenDocValueIT extends FlattenDocValueIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteGeoIpFunctionsIT.java

@@ -12,6 +12,5 @@ public class CalciteGeoIpFunctionsIT extends GeoIpFunctionsIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteGeoPointFormatsIT.java

@@ -13,7 +13,6 @@ public class CalciteGeoPointFormatsIT extends GeoPointFormatsIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteHeadCommandIT.java

@@ -12,6 +12,5 @@ public class CalciteHeadCommandIT extends HeadCommandIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteIPComparisonIT.java

@@ -12,6 +12,5 @@ public class CalciteIPComparisonIT extends IPComparisonIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteIPFunctionsIT.java

@@ -13,7 +13,6 @@ public class CalciteIPFunctionsIT extends IPFunctionsIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteInformationSchemaCommandIT.java

@@ -14,7 +14,5 @@ public class CalciteInformationSchemaCommandIT extends InformationSchemaCommandI
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    // TODO: "https://github.com/opensearch-project/sql/issues/3455"
-    // disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteJsonFunctionsIT.java

@@ -8,13 +8,11 @@
 import org.junit.Ignore;
 import org.opensearch.sql.ppl.JsonFunctionsIT;
 
-@Ignore
+@Ignore("https://github.com/opensearch-project/sql/issues/3436")
 public class CalciteJsonFunctionsIT extends JsonFunctionsIT {
   @Override
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    // TODO: "https://github.com/opensearch-project/sql/issues/3436"
-    // disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteLegacyAPICompatibilityIT.java

@@ -12,6 +12,5 @@ public class CalciteLegacyAPICompatibilityIT extends LegacyAPICompatibilityIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteLikeQueryIT.java

@@ -15,7 +15,6 @@ public class CalciteLikeQueryIT extends LikeQueryIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMatchBoolPrefixIT.java

@@ -12,6 +12,5 @@ public class CalciteMatchBoolPrefixIT extends MatchBoolPrefixIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMatchIT.java

@@ -12,6 +12,5 @@ public class CalciteMatchIT extends MatchIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMatchPhraseIT.java

@@ -12,6 +12,5 @@ public class CalciteMatchPhraseIT extends MatchPhraseIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMatchPhrasePrefixIT.java

@@ -12,6 +12,5 @@ public class CalciteMatchPhrasePrefixIT extends MatchPhrasePrefixIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMathematicalFunctionIT.java

@@ -12,6 +12,5 @@ public class CalciteMathematicalFunctionIT extends MathematicalFunctionIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteMultiMatchIT.java

@@ -12,6 +12,5 @@ public class CalciteMultiMatchIT extends MultiMatchIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteNewAddedCommandsIT.java

@@ -12,6 +12,5 @@ public class CalciteNewAddedCommandsIT extends NewAddedCommandsIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteNowLikeFunctionIT.java

@@ -27,6 +27,5 @@ public CalciteNowLikeFunctionIT(
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteObjectFieldOperateIT.java

@@ -12,6 +12,5 @@ public class CalciteObjectFieldOperateIT extends ObjectFieldOperateIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 }

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteOperatorIT.java

@@ -13,7 +13,6 @@ public class CalciteOperatorIT extends OperatorIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Override

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLAggregationIT.java

@@ -32,7 +32,6 @@ public class CalcitePPLAggregationIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.BANK);
     loadIndex(Index.BANK_WITH_NULL_VALUES);

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLAppendcolIT.java

@@ -21,7 +21,6 @@ public class CalcitePPLAppendcolIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
     loadIndex(Index.ACCOUNT);
   }
 

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLBasicIT.java

@@ -26,7 +26,6 @@ public class CalcitePPLBasicIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     Request request1 = new Request("PUT", "/test/_doc/1?refresh=true");
     request1.setJsonEntity("{\"name\": \"hello\", \"age\": 20}");

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLBuiltinDatetimeFunctionInvalidIT.java

@@ -18,7 +18,6 @@ public class CalcitePPLBuiltinDatetimeFunctionInvalidIT extends PPLIntegTestCase
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(SQLIntegTestCase.Index.STATE_COUNTRY);
     loadIndex(SQLIntegTestCase.Index.STATE_COUNTRY_WITH_NULL);

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLBuiltinFunctionIT.java

@@ -27,7 +27,6 @@ public class CalcitePPLBuiltinFunctionIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.STATE_COUNTRY);
     loadIndex(Index.DATA_TYPE_NUMERIC);

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLBuiltinFunctionsNullIT.java

@@ -23,7 +23,6 @@ public class CalcitePPLBuiltinFunctionsNullIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.STATE_COUNTRY);
     loadIndex(Index.STATE_COUNTRY_WITH_NULL);

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLCaseFunctionIT.java

@@ -23,7 +23,6 @@ public class CalcitePPLCaseFunctionIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.WEBLOG);
     appendDataForBadResponse();

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLCastFunctionIT.java

@@ -26,7 +26,6 @@ public class CalcitePPLCastFunctionIT extends CastFunctionIT {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
   }
 
   @Test

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLConditionBuiltinFunctionIT.java

@@ -20,7 +20,6 @@ public class CalcitePPLConditionBuiltinFunctionIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.STATE_COUNTRY);
     loadIndex(Index.STATE_COUNTRY_WITH_NULL);

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLCryptographicFunctionIT.java

@@ -22,7 +22,6 @@ public class CalcitePPLCryptographicFunctionIT extends PPLIntegTestCase {
   public void init() throws Exception {
     super.init();
     enableCalcite();
-    disallowCalciteFallback();
 
     loadIndex(Index.STATE_COUNTRY);
   }