-
Notifications
You must be signed in to change notification settings - Fork 181
Filter expression with OR isnull(x) should be pushed down
#4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter expression with OR isnull(x) should be pushed down
#4055
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
isnull or other expression should be pushed downOR isnull(x) should be pushed down
| .anyMatch( | ||
| o -> | ||
| o.getKind() == SqlKind.OTHER | ||
| && ((RexCall) o).getOperator().equals(SqlStdOperatorTable.IS_EMPTY)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we check other functions as well? e.g. LENGTH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function LENGTH support accepting NULL as its arguments. No need to change.
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4055-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fce8383d56444092eed01b01b889fc6e4be4e810
# Push it to GitHub
git push --set-upstream origin backport/backport-4055-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
…ch-project#4055) * Filter with isnull or other expression should be pushded down Signed-off-by: Lantao Jin <ltjin@amazon.com> * revert unexpected deletion Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix conflicts Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit fce8383)
Description
Filter expression with
OR isnull(x)should be pushed down in Calcite engineExample:
Should be pushed down to
Related Issues
Resolves #4046
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.