Support push down sort on aggregation measure for more than one agg call #4759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
added
enhancement
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
qianheng-aws
approved these changes
Nov 10, 2025
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4759-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d548b9b66652cb24bd705f5074b77ec4ecdcaa3
# Push it to GitHub
git push --set-upstream origin backport/backport-4759-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Nov 10, 2025
…alls (opensearch-project#4759) Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 3d548b9)
yuancu
pushed a commit
that referenced
this pull request
Nov 10, 2025
… more than one agg calls (#4759) (#4767) * Support push down sort on aggregation measure for more than one agg calls (#4759) Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 3d548b9) * Fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
…alls (opensearch-project#4759) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AggPushDownActionto remove deduped codesOpenSearchRelBuilderin RelRule.ConfigRelated Issues
Resolves #4737
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.