Translate SAFE_CAST to TRY_CAST in Spark SQL
#4788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
changed the title
SAFE_CAST to TRY_CAST in Spark SQL
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
qianheng-aws
approved these changes
Nov 12, 2025
yuancu
approved these changes
Nov 12, 2025
| "ARG_MAX", "MAX_BY", | ||
| "SAFE_CAST", "TRY_CAST"); | ||
|
|
||
| private static final Map<String, String> CALL_SEPARATOR = ImmutableMap.of("SAFE_CAST", "AS"); |
Collaborator
There was a problem hiding this comment.
[nit] ARGUMENT_SEPARATOR might be a better name
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit b5fe1c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Nov 12, 2025
(cherry picked from commit b5fe1c1) Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
asifabashar
pushed a commit
to asifabashar/sql
that referenced
this pull request
Dec 10, 2025
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SAFE_CASTtoTRY_CASTin Spark SQLMAX_BYandMIN_BYfunctions in Spark SQLRelated Issues
Resolves #4778
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.