[Backport main] Update 3.4 release Note (#4923)#4934
[Backport main] Update 3.4 release Note (#4923)#4934LantaoJin merged 1 commit intoopensearch-project:mainfrom
Conversation
* Update 3.4 doc Signed-off-by: Kai Huang <ahkcs@amazon.com> * update Signed-off-by: Kai Huang <ahkcs@amazon.com> * updates Signed-off-by: Kai Huang <ahkcs@amazon.com> * Update Signed-off-by: Kai Huang <ahkcs@amazon.com> --------- Signed-off-by: Kai Huang <ahkcs@amazon.com> (cherry picked from commit c87f99f)
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughA release notes document for OpenSearch SQL version 3.4.0 is added, detailing features, enhancements, bug fixes, infrastructure updates, documentation improvements, and maintenance activities via bullet-point entries with PR references. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
release-notes/opensearch-sql.release-notes-3.4.0.0.md (2)
14-14: Standardize terminology: use either "regex" or "regexp" consistently.The document mixes "regexp_replace" (line 14), "regex" (line 52), and "Regex" (line 58). Choose one variant and apply consistently throughout. The term "regex" is more common in technical documentation.
- * Add `regexp_replace()` function as alias of `replace()` ([#4765](https://github.com/opensearch-project/sql/pull/4765)) + * Add `regex_replace()` function as alias of `replace()` ([#4765](https://github.com/opensearch-project/sql/pull/4765))- * [Enhancement] Error handling for illegal character usage in java regex named capture group ([#4434](https://github.com/opensearch-project/sql/pull/4434)) + * [Enhancement] Error handling for illegal character usage in Java regex named capture group ([#4434](https://github.com/opensearch-project/sql/pull/4434))- * Support Regex for replace eval function ([#4456](https://github.com/opensearch-project/sql/pull/4456)) + * Support regex for replace eval function ([#4456](https://github.com/opensearch-project/sql/pull/4456))Also applies to: 52-52, 58-58
117-117: Capitalize "GitHub" consistently with official branding.Line 117 uses lowercase "github" but the official name is "GitHub".
- * Update github workflows to move from macos-13 to 14 ([#4779](https://github.com/opensearch-project/sql/pull/4779)) + * Update GitHub workflows to move from macos-13 to 14 ([#4779](https://github.com/opensearch-project/sql/pull/4779))
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
release-notes/opensearch-sql.release-notes-3.4.0.0.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-02T17:27:55.938Z
Learnt from: CR
Repo: opensearch-project/sql PR: 0
File: .rules/REVIEW_GUIDELINES.md:0-0
Timestamp: 2025-12-02T17:27:55.938Z
Learning: Test SQL generation and optimization paths for Calcite integration changes
Applied to files:
release-notes/opensearch-sql.release-notes-3.4.0.0.md
🪛 LanguageTool
release-notes/opensearch-sql.release-notes-3.4.0.0.md
[uncategorized] ~52-~52: Do not mix variants of the same word (‘regex’ and ‘regexp’) within a single text.
Context: ...ing for illegal character usage in java regex named capture group ([#4434](https://gi...
(EN_WORD_COHERENCY)
[uncategorized] ~58-~58: Do not mix variants of the same word (‘regex’ and ‘regexp’) within a single text.
Context: ...earch-project/sql/pull/4477)) * Support Regex for replace eval function ([#4456](http...
(EN_WORD_COHERENCY)
[uncategorized] ~117-~117: The official name of this software platform is spelled with a capital “H”.
Context: ...search-project/sql/pull/4716)) * Update github workflows to move from macos-13 to 14 (...
(GITHUB)
🪛 markdownlint-cli2 (0.18.1)
release-notes/opensearch-sql.release-notes-3.4.0.0.md
112-112: Spaces inside emphasis markers
(MD037, no-space-in-emphasis)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: build-linux (21, integration)
- GitHub Check: build-linux (25, unit)
- GitHub Check: build-linux (21, unit)
- GitHub Check: build-linux (25, integration)
- GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, integration)
- GitHub Check: build-windows-macos (macos-14, 25, integration)
- GitHub Check: build-windows-macos (macos-14, 21, integration)
- GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, unit)
- GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, integration)
- GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, unit)
- GitHub Check: build-windows-macos (macos-14, 21, unit)
- GitHub Check: CodeQL-Scan (java)
Update 3.4 doc
(cherry picked from commit c87f99f)