Skip to content

Conversation

@Parasjg
Copy link

@Parasjg Parasjg commented Dec 24, 2025

Sync up this path publish-async-query-core.yml from main to 2.19-dev and also changing the JAVA to 17

Description

Sync up this path publish-async-query-core.yml from main to 2.19-dev and also changing the JAVA to 17

Related Issues

Resolving issue related to java version when upadating the async-query-core jars in DQS

Check List

  • [NA] New functionality includes testing.
  • [NA] New functionality has been documented.
  • [NA] New functionality has javadoc added.
  • [NA] New functionality has a user manual doc added.
  • [NA] New PPL command checklist all confirmed.
  • [NA] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • [NA] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…and also changing the JAVA to 17

Signed-off-by: Paras jaggi <parasjg@amazon.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

with:
distribution: temurin
java-version: 21
java-version: 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be 11 for 2.19?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We connected with Kai Huang , he suggested 17 could work . Do let me know if we can't go ahead with this one.

Copy link
Contributor

@ahkcs ahkcs Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use JDK 17 for async query core jar here and main branch doesn't support 17, that's why I suggested them to backport the maven snapshot upload logic to 2.19-dev branch with JDK 17 supported, please let me know if there's any concerns for this

Copy link
Contributor

@ahkcs ahkcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Swiddis Swiddis merged commit 5ea1c09 into opensearch-project:2.19-dev Jan 6, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants