Adopt appendcol, appendpipe, multisearch to spath#5075
Adopt appendcol, appendpipe, multisearch to spath#5075ykmr1224 merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR modifies field resolution and dynamic field handling to allow spath-related commands (appendcol, appendpipe, multisearch) to work with dynamic fields. The changes replace exception-throwing behavior with verification delegation to subqueries/subsearches, add bulk input alignment logic for dynamic fields, and extend test coverage. Documentation is updated to reflect that appendcol and multisearch are no longer restricted with spath. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.40.5)core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.javaComment |
…#5075) Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-5075-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7630db831f2e4c453f32f958e84e0a26ec4c176f
# Push it to GitHub
git push --set-upstream origin backport/backport-5075-to-2.19-dev
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
Description
Related Issues
#4984
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.