[Backport 1.x] Bug Fix, return default ID when log4j ThreadContext is empty #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: penghuo <penghuo@gmail.com> (cherry picked from commit 54b7257)
Codecov Report
@@ Coverage Diff @@
## 1.x #539 +/- ##
============================================
- Coverage 95.25% 95.23% -0.02%
+ Complexity 2746 2744 -2
============================================
Files 276 276
Lines 7416 7410 -6
Branches 544 538 -6
============================================
- Hits 7064 7057 -7
- Misses 298 299 +1
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
penghuo
approved these changes
Apr 6, 2022
penghuo
pushed a commit
that referenced
this pull request
Apr 8, 2022
ps48
added a commit
that referenced
this pull request
Jul 28, 2022
* Disable flaky test in JdbcTestIT. (#475) Signed-off-by: penghuo <penghuo@gmail.com> * Update dependency opensearch-ml-client group name (#477) Signed-off-by: jackieyanghan <jkhanjob@gmail.com> * Collected fixes related to bugs #280, #302, #783, #696 and 317 all together. (#479) Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Add JDK 8 to CI Matrix (#483) (#484) * fixed references in java 8 and added to ci matrix * filter test that fails due to jdk 8 bug * use different degree to radian conversion for difference in jdk * skip date time format tests that cause error due to jdk bug * only disable DateTime unit test on Java 8 Bypassing failed DCO check Signed-off-by: David Cui <davidcui@amazon.com> (cherry picked from commit b6fccbd) Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com> * Add parse docs to PPL commands index (#486) (#487) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add 1.3.0 release notes (#492) Signed-off-by: Eugene Lee <eugenesk@amazon.com> * Add Kmeans and AD command documentation (#493) (#497) Signed-off-by: jackieyanghan <jkhanjob@gmail.com> (cherry picked from commit ee4bce0) * Bump version to 1.3.1 Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Bump ml Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Add new zip Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Updated release drafter Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Remove checked-in ml-commons dependency (#529) Signed-off-by: jackieyanghan <jkhanjob@gmail.com> * Bump workbench to 1.3.1 (#540) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bug Fix, return default ID when log4j ThreadContext is empty (#538) (#539) (#543) Signed-off-by: penghuo <penghuo@gmail.com> (cherry picked from commit 54b7257) * Incremented version to 1.3.2. (#593) Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * Version bump 1.3.3 Signed-off-by: pgodithi <pgodithi@amazon.com> * [1.3] Bump spring-beans to 5.2.20 (#632) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Version bump 1.3.3 Signed-off-by: pgodithi <pgodithi@amazon.com> * Incremented version to 1.3.4. (#681) * Incremented version to 1.3.4. Signed-off-by: Zelin Hao <zelinhao@amazon.com> * bump jackson to 2.13.2 Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Peng Huo <penghuo@gmail.com> Co-authored-by: Jackie Han <41348518+jackiehanyang@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com> Co-authored-by: Eugene Lee <eugenesk@amazon.com> Co-authored-by: Sayali Gaikawad <gaiksaya@amazon.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com> Co-authored-by: pgodithi <pgodithi@amazon.com> Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 54b7257 from #538