-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support querying a data stream #56
Conversation
Thanks for contributing this PR! Could you fix the unit test error in Github action?
|
@dai-chen Fixed the broken unit-tests. We are adding data streams' support in OpenSearch which is being tracked here: opensearch-project/OpenSearch#675 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just wondering any chance to add IT for this new feature? Example: https://github.com/opensearch-project/sql/blob/develop/integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/IdentifierIT.java
Sorry I just realized that my PR renaming all packages to |
…a stream. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
@dai-chen No worries! I have rebased with the 'develop' branch. |
Description
Fixed index expression resolution to include backing indices of a data stream. This will make querying a data stream consistent with querying an index alias.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Ketan Verma ketan9495@gmail.com