-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integ relevance function it fix #608
Integ relevance function it fix #608
Conversation
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…r instances of executeJdbcRequest functions in other classes Signed-off-by: forestmvey <forestv@bitquilltech.com>
Relevance Function Integration Test Fix
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=========================================
Coverage 94.59% 94.59%
- Complexity 2742 2743 +1
=========================================
Files 276 276
Lines 7454 7455 +1
Branches 550 552 +2
=========================================
+ Hits 7051 7052 +1
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Just curious how this IT (without FROM clause) can pass earlier?
Integration tests are based on JUnit4, not JUnit5 so the test was not being run. |
Description
Integration test failing with base class using JUnit4. Integration test queries required FROM clause in SELECT statements.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.