Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integ relevance function it fix #608

Merged

Conversation

forestmvey
Copy link
Collaborator

Description

Integration test failing with base class using JUnit4. Integration test queries required FROM clause in SELECT statements.

Check List

  • New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

forestmvey and others added 3 commits May 12, 2022 11:06
Signed-off-by: forestmvey <forestv@bitquilltech.com>
…r instances of executeJdbcRequest functions in other classes

Signed-off-by: forestmvey <forestv@bitquilltech.com>
@forestmvey forestmvey requested a review from a team as a code owner May 13, 2022 18:27
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #608 (5627112) into main (6fda8f7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #608   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
- Complexity     2742     2743    +1     
=========================================
  Files           276      276           
  Lines          7454     7455    +1     
  Branches        550      552    +2     
=========================================
+ Hits           7051     7052    +1     
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
...opensearch/planner/physical/MLCommonsOperator.java 12.12% <0.00%> (ø)
...rch/planner/physical/MLCommonsOperatorActions.java 1.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fda8f7...5627112. Read the comment docs.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just curious how this IT (without FROM clause) can pass earlier?

@forestmvey
Copy link
Collaborator Author

Thanks for the fix! Just curious how this IT (without FROM clause) can pass earlier?

Integration tests are based on JUnit4, not JUnit5 so the test was not being run.

@joshuali925 joshuali925 merged commit 810ffcc into opensearch-project:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants