Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODBC folder, file and code renaming #62

Merged
merged 7 commits into from
May 18, 2021

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 18, 2021

Description

Replace ODFE in folder name, file name and source code. Mac artifact is installed and tested.

TODO:

  1. Update screenshots in all doc in separate PR. (Test Windows artifact here)
  2. There are still ODFE in SqlOdbcPBIConnector.mez which is binary. Need to check how to re-generate this file in to-do item OpenSearch migration for SQL/PPL #1.

Issues Resolved

#36

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dai-chen added 7 commits May 17, 2021 11:42
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen self-assigned this May 18, 2021
@dai-chen dai-chen marked this pull request as ready for review May 18, 2021 18:23
@dai-chen dai-chen requested review from chloe-zh and penghuo May 18, 2021 18:24
@dai-chen dai-chen merged commit 7bd9700 into opensearch-project:develop May 18, 2021
@dai-chen dai-chen deleted the odbc-odfe-renaming branch May 18, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants