Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql offending symbol due to keyword as an ID #652

Closed
wants to merge 1 commit into from
Closed

Fix sql offending symbol due to keyword as an ID #652

wants to merge 1 commit into from

Conversation

seankao-az
Copy link
Collaborator

Description

This PR allows SQL to parse pattern matching query correctly for identifiers that contain keywords.

Issues Resolved

#650

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sean Kao <seankao@amazon.com>
@seankao-az seankao-az linked an issue Jun 22, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #652 (890fc1d) into main (d81ef73) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #652   +/-   ##
=========================================
  Coverage     94.63%   94.63%           
  Complexity     2777     2777           
=========================================
  Files           279      279           
  Lines          7517     7517           
  Branches        556      556           
=========================================
  Hits           7114     7114           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81ef73...890fc1d. Read the comment docs.

@penghuo penghuo closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SQL describe query with column filter changes response format
3 participants