-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change plugin folder name to opensearch-sql #662
Conversation
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.1 #662 +/- ##
=============================================
- Coverage 94.67% 62.76% -31.92%
=============================================
Files 280 10 -270
Lines 7570 658 -6912
Branches 558 119 -439
=============================================
- Hits 7167 413 -6754
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also port this PR to main
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
testing the build locally. once its successful i'll reopen the PR |
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also change :plugin
in https://github.com/opensearch-project/sql/blob/main/DEVELOPER_GUIDE.rst#opensearch-opensearch-dashboards
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
yup, changed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM
|
Signed-off-by: Kavitha Conjeevaram Mohan mohakavi@amazon.com
Description
Changing sql/plugin folder name to sql/opensearch-sql to fix getting unknown plugin error in OpenSearch maven build. This change provides name to sql plugin when built in opensearch
Update: changing plugin name didn’t work so adding settings.gradle file to plugin folder
Issues Resolved
closes #660
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.