Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change plugin folder name to opensearch-sql #662

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

kavithacm
Copy link
Collaborator

@kavithacm kavithacm commented Jun 28, 2022

Signed-off-by: Kavitha Conjeevaram Mohan mohakavi@amazon.com

Description

Changing sql/plugin folder name to sql/opensearch-sql to fix getting unknown plugin error in OpenSearch maven build. This change provides name to sql plugin when built in opensearch

Update: changing plugin name didn’t work so adding settings.gradle file to plugin folder

Issues Resolved

closes #660

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm requested a review from a team as a code owner June 28, 2022 17:39
@kavithacm kavithacm self-assigned this Jun 28, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #662 (9a0e6c9) into 2.1 (7cbb121) will decrease coverage by 31.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.1     #662       +/-   ##
=============================================
- Coverage     94.67%   62.76%   -31.92%     
=============================================
  Files           280       10      -270     
  Lines          7570      658     -6912     
  Branches        558      119      -439     
=============================================
- Hits           7167      413     -6754     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opensearch/planner/physical/MLCommonsOperator.java
.../expression/operator/convert/TypeCastOperator.java
...ensearch/storage/system/OpenSearchSystemIndex.java
...h/planner/logical/rule/MergeFilterAndRelation.java
...nsearch/sql/expression/window/WindowFunctions.java
...org/opensearch/sql/sql/domain/SQLQueryRequest.java
...nsearch/data/value/OpenSearchExprValueFactory.java
...ain/java/org/opensearch/sql/analysis/Analyzer.java
...rg/opensearch/sql/planner/logical/LogicalEval.java
...java/org/opensearch/sql/sql/parser/AstBuilder.java
... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbb121...9a0e6c9. Read the comment docs.

joshuali925
joshuali925 previously approved these changes Jun 28, 2022
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also port this PR to main

mengweieric
mengweieric previously approved these changes Jun 28, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm dismissed stale reviews from mengweieric and joshuali925 via e27e119 June 28, 2022 22:10
@kavithacm kavithacm marked this pull request as draft June 29, 2022 19:03
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm closed this Jun 29, 2022
@kavithacm
Copy link
Collaborator Author

testing the build locally. once its successful i'll reopen the PR

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm reopened this Jun 29, 2022
@kavithacm kavithacm marked this pull request as ready for review June 29, 2022 20:19
@kavithacm kavithacm requested a review from a team June 29, 2022 20:33
joshuali925
joshuali925 previously approved these changes Jun 29, 2022
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vmmusings
vmmusings previously approved these changes Jun 29, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm kavithacm dismissed stale reviews from vmmusings and joshuali925 via 3e06479 June 29, 2022 20:47
@kavithacm
Copy link
Collaborator Author

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavithacm kavithacm requested a review from vmmusings June 29, 2022 21:17
@kavithacm kavithacm requested a review from mengweieric June 29, 2022 21:17
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jun 29, 2022

LGTM
./gradlew properties lists opensearch-sql-plugin

allprojects: [root project 'opensearch-sql', project ':common', project ':core', project ':doctest', project ':integ-test', project ':legacy', project ':opensearch', project ':opensearch-sql-plugin', project ':ppl', project ':protocol', project ':sql']

@kavithacm kavithacm merged commit 5f00b9f into opensearch-project:2.1 Jun 29, 2022
joshuali925 pushed a commit that referenced this pull request Jun 29, 2022
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants