Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fuzziness parsing in multi_match function. Update tests. #668

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Fix fuzziness parsing in multi_match function. Update tests. #668

merged 2 commits into from
Jun 29, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com

Description

Hotfix for PR #649.

Issues Resolved

Fix fuzziness parsing in multi_match query builder. Tests are updated to extend coverage.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 2 commits June 29, 2022 12:49
@Yury-Fridlyand
Fix fuzziness parsing in multi_match function. Update tests.
af29809 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Merge pull request #83 from Bit-Quill/dev-fuzziness-fix-for-multi_match
b0ff1c6 
Fix `fuzziness` parsing in `multi_match` function. Update tests.
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner June 29, 2022 21:39
joshuali925
joshuali925 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit a91c194 into opensearch-project:main Jun 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
@Yury-Fridlyand @github-actions
Fix fuzziness parsing in multi_match function. Update tests. (#668)
2dce080 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
(cherry picked from commit a91c194)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 29, 2022
Merged
joshuali925 pushed a commit that referenced this pull request Jun 29, 2022
@opensearch-trigger-bot @Yury-Fridlyand
Fix fuzziness parsing in multi_match function. Update tests. (#668)…
864732a 
… (#669)

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
(cherry picked from commit a91c194)

Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com>
acarbonetto
acarbonetto reviewed Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@forestmvey forestmvey mentioned this pull request Jun 30, 2022
Closed
@Yury-Fridlyand Yury-Fridlyand deleted the integ-fuzziness-fix-for-multi_match branch July 5, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto left review comments

@joshuali925 joshuali925 joshuali925 approved these changes

@kavithacm kavithacm kavithacm approved these changes

Assignees
No one assigned
Labels
backport 2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yury-Fridlyand @kavithacm @joshuali925 @acarbonetto