-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workbench documentation links, complete renaming #67
Conversation
Signed-off-by: David Cui <davidcui@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will there be a change on renaming _opensearch
to _plugins
in API?
sql/workbench/server/services/utils/constants.ts
Lines 29 to 32 in 2ea5df6
export const SQL_TRANSLATE_ROUTE = `/_opensearch/_sql/_explain`; | |
export const PPL_TRANSLATE_ROUTE = `/_opensearch/_ppl/_explain`; | |
export const SQL_QUERY_ROUTE = `/_opensearch/_sql`; | |
export const PPL_QUERY_ROUTE = `/_opensearch/_ppl`; |
Good catch, I missed that. I assume you're referring to https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#rest-apis-backward-compatibility ? |
I've posted PR for that: #66. Endpoints in JDBC/ODBC, CLI and Workbench are all changed accordingly. |
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui davidcui@amazon.com
Description
opendistro
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.