Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workbench documentation links, complete renaming #67

Merged
merged 2 commits into from
May 19, 2021

Conversation

davidcui1225
Copy link
Contributor

Signed-off-by: David Cui davidcui@amazon.com

Description

  • Update documentation links to OpenSearch
  • Rename remaining occurrences of opendistro

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Cui <davidcui@amazon.com>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be a change on renaming _opensearch to _plugins in API?

export const SQL_TRANSLATE_ROUTE = `/_opensearch/_sql/_explain`;
export const PPL_TRANSLATE_ROUTE = `/_opensearch/_ppl/_explain`;
export const SQL_QUERY_ROUTE = `/_opensearch/_sql`;
export const PPL_QUERY_ROUTE = `/_opensearch/_ppl`;

workbench/common/index.ts Outdated Show resolved Hide resolved
workbench/server/plugin.ts Outdated Show resolved Hide resolved
workbench/server/plugin.ts Outdated Show resolved Hide resolved
@davidcui1225
Copy link
Contributor Author

will there be a change on renaming _opensearch to _plugins in API?

export const SQL_TRANSLATE_ROUTE = `/_opensearch/_sql/_explain`;
export const PPL_TRANSLATE_ROUTE = `/_opensearch/_ppl/_explain`;
export const SQL_QUERY_ROUTE = `/_opensearch/_sql`;
export const PPL_QUERY_ROUTE = `/_opensearch/_ppl`;

Good catch, I missed that. I assume you're referring to https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#rest-apis-backward-compatibility ?

@dai-chen
Copy link
Collaborator

dai-chen commented May 18, 2021

will there be a change on renaming _opensearch to _plugins in API?

export const SQL_TRANSLATE_ROUTE = `/_opensearch/_sql/_explain`;
export const PPL_TRANSLATE_ROUTE = `/_opensearch/_ppl/_explain`;
export const SQL_QUERY_ROUTE = `/_opensearch/_sql`;
export const PPL_QUERY_ROUTE = `/_opensearch/_ppl`;

Good catch, I missed that. I assume you're referring to https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#rest-apis-backward-compatibility ?

I've posted PR for that: #66. Endpoints in JDBC/ODBC, CLI and Workbench are all changed accordingly.

Signed-off-by: David Cui <davidcui@amazon.com>
@davidcui1225 davidcui1225 requested a review from dblock May 18, 2021 23:05
@davidcui1225 davidcui1225 merged commit e4692ba into develop May 19, 2021
@davidcui1225 davidcui1225 deleted the workbench-odfe-compatibility branch May 19, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants