-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove opensearch.sql.engine.new.enabled setting #70
Conversation
Signed-off-by: penghuo <penghuo@gmail.com>
Here is another doc that needs to be updated: https://github.com/opensearch-project/sql/blob/main/docs/dev/NewSQLEngine.md#34-what-if-something-wrong |
Done. https://github.com/penghuo/os-sql/blob/pr-issue58/docs/dev/NewSQLEngine.md |
… because there is no enough memory Signed-off-by: penghuo <penghuo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: penghuo penghuo@gmail.com
Description
Remove the opensearch.sql.engine.new.enabled. The opensearch.sql.engine.new.enabled setting is added and set to default true on ODFE 1.13.0.0, the major purpose is to safely publish the new engine, in any case, the customer found issue, they still have the way to rollback to the legacy engine.
We didn't found major issue with new engine, so we decide to fullly enable it by default. If there are any case the new engine can't handle, it still fallback to the the legacy engine automatically. So, there is no impact for the customer.
Issues Resolved
#58
To Reviewers
The PR include the following changes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.