-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds plan context for Scroll physical plan building #713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
changed the title
Adds plan context for physical plan building
Adds plan context for Scroll physical plan building
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #713 +/- ##
=============================================
- Coverage 94.74% 62.76% -31.99%
=============================================
Files 283 10 -273
Lines 7676 658 -7018
Branches 560 118 -442
=============================================
- Hits 7273 413 -6860
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Sean Kao <seankao@amazon.com>
6 tasks
The PlanContext isn't that useful compared to its added complexity to the overall design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds plan context that can be modified during request handling and/or logical plan analysis. It is then used to help build the physical plan. Right now it has only one field, namely, IndexScanMode,
IndexScanType
, which decides whether to invoke a regular query request or a scroll request to OpenSearch.Before:
logical plan => physical plan
After:
(logical plan, plan context) => physical plan
An example use case is to distinguish scrolling requests from regular query requests ([FEATURE] - Support pagination for PPL and SQL query #656) . Both of them can have the exact same query, and therefore, have the exact same logical plan. They differ only in the underlying index scan operator choice.
We can set the index scan type to SCROLL during request handling.
Another use case is to allow for some commands to request more data rows than
query.size_limit
andindex.max_result_window
(Extend size_limit setting in query engine to support unlimited index query. #703).Pull opensearch index scan results in batches, rather than loading all at once.
Issues Resolved
This is a building block for both #656 and #703
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.