[Backport 2.x] Add maketime and makedate datetime functions
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
joshuali925
approved these changes
Aug 17, 2022
|
I just merged the backport PR #761 for Workbench failure. |
dai-chen
approved these changes
Aug 17, 2022
|
DCO failed due to : "Can not find "Yury-Fridlyand yuryf@bitquilltech.com", in ["Yury Fridlyand yuryf@bitquilltech.com", "Yury Fridlyand yuryf@bitquilltech.com"]" |
|
Damn again, I'm going to hate DCO! |
I ran into similar problem recently on backport PR and found my Github no-reply email was used in my previous commit :( |
|
i think for backport PRs it's ok, just make sure your local git config user.name and user.email is consistent with github settings displayed name and email so future backports DCO won't fail. i explained a bit in #706 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9f602c3 from #755