Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test in PowerBI connector. #800

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com

Description

Last time we updated PowerBI connector, we missed to update embedded unit tests.
These tests may be executed by a developer only. To run tests you need to install PowerQuerySDK for Visual Studio, open mproj file (bi-connectors/PowerBIConnector/src/OpenSearchProject.mproj) with Visual Studio and run it.

Issues Resolved

Before

image
image

After

image
image

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 3, 2022 02:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #800 (019c01b) into main (4e40ed2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #800   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2910     2910           
=========================================
  Files           288      288           
  Lines          7830     7830           
  Branches        570      570           
=========================================
  Hits           7427     7427           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Wondering if we can run this UT automatically in Github action? Is this UT or IT that requires PowerBI instance?

@Yury-Fridlyand
Copy link
Collaborator Author

Yury-Fridlyand commented Sep 6, 2022

Thanks for the fix! Wondering if we can run this UT automatically in Github action? Is this UT or IT that requires PowerBI instance?

It is a kind of IT.
These tests require Visual Studio, PowerQuery SDK and an OpenSearch cluster running, PowerBI is not required.
Unfortunately, I don't know how to run these tests in headless mode (without UI) and/or without Visual Studio.

@penghuo penghuo merged commit 8a7b329 into opensearch-project:main Sep 7, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the fix-pbi-connector-ut branch September 7, 2022 18:33
@dai-chen dai-chen added bug Something isn't working powerBI labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working powerBI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants