Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DELETE clause by defaut and add opensearch.sql.delete.enabled setting #81

Merged
merged 5 commits into from
May 21, 2021

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented May 20, 2021

Description

  1. By default, the DELETE clause is disabled in SQL engine.
  2. Add the opensearch.sql.delete.enabled setting which could be used to enable the DELETE clause.
  3. Update the docs, https://github.com/penghuo/os-sql/blob/pr-issue59/docs/user/admin/settings.rst#opensearch-sql-delete-enabled

Issues Resolved

#59

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

penghuo added 4 commits May 20, 2021 12:27
… setting

Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review May 20, 2021 23:24
@penghuo penghuo requested review from dai-chen and chloe-zh May 20, 2021 23:27
@penghuo penghuo self-assigned this May 20, 2021
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

docs/user/admin/settings.rst Outdated Show resolved Hide resolved
Signed-off-by: penghuo <penghuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants