Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text functions ASCII, LEFT, LOCATE, REPLACE in new engine #88

Merged
merged 9 commits into from
May 24, 2021

Conversation

chloe-zh
Copy link
Contributor

@chloe-zh chloe-zh commented May 24, 2021

Signed-off-by: chloe-zh chloezh1102@gmail.com

Description

[Describe what this change achieves]

Issues Resolved

#87
#74
#73

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: chloe-zh <chloezh1102@gmail.com>
chloe-zh added 3 commits May 24, 2021 12:50
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh self-assigned this May 24, 2021
@chloe-zh chloe-zh requested a review from dai-chen May 24, 2021 21:33
@chloe-zh chloe-zh marked this pull request as ready for review May 24, 2021 21:33
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Does PPL need any one of these functions?

chloe-zh added 4 commits May 24, 2021 14:50
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh merged commit 6355810 into opensearch-project:develop May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants