AD timefield name issue #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Zhang <jngz@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #919 +/- ##
============================================
- Coverage 97.90% 95.10% -2.81%
Complexity 3072 3072
============================================
Files 293 303 +10
Lines 7588 8247 +659
Branches 490 609 +119
============================================
+ Hits 7429 7843 +414
- Misses 158 350 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Could you add UT for the changes? |
joshuali925
previously approved these changes
Oct 19, 2022
|
any tests on AD? |
|
Looks like the existing UT doesn't cover the full project logic, I will rewrite it. |
MaxKsyunz
previously approved these changes
Oct 26, 2022
jngz-es
requested review from
penghuo,
joshuali925 and
MaxKsyunz
and removed request for
joshuali925,
penghuo and
MaxKsyunz
penghuo
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch-project/ml-commons#467
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.