Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDBC driver version #941

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Oct 20, 2022

Description

Updated the version of the JDBC driver to 2.0.0.0.
Created a test to make sure the jar file version and the version shown in the debug logs match.

Issues Resolved

#903
#900

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Guian Gumpac added 3 commits October 18, 2022 21:11
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@GumpacG GumpacG requested a review from a team as a code owner October 20, 2022 16:13
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Just to confirm, in future, the JDBC version will only bump if any change or along with major OpenSearch version release, right?

@dai-chen dai-chen added JDBC bug Something isn't working labels Oct 20, 2022
@dai-chen dai-chen merged commit 05d53e7 into opensearch-project:2.x Oct 20, 2022
@GumpacG GumpacG deleted the integ-update-jdbc-version branch October 20, 2022 23:04
@GumpacG
Copy link
Collaborator Author

GumpacG commented Oct 20, 2022

Thanks for the fix!

Just to confirm, in future, the JDBC version will only bump if any change or along with major OpenSearch version release, right?

Yes. The JDBC version should only bump in those cases.

penghuo pushed a commit to penghuo/os-sql that referenced this pull request Oct 21, 2022
* Bumped the JDBC driver version to 2.0.0.0

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>

* Added a test to ensure versions match in the jar file and debug messages

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants