Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing cd in README.MD Running test locally #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SkollRyu
Copy link

@SkollRyu SkollRyu commented Nov 8, 2023

Description

./script/install-tools
export OSS_IMAGE="opensearchproject/opensearch:2"
docker-compose up -d
docker-compose ps -a
export OPENSEARCH_URL=http://admin:admin@localhost:9200
export TF_LOG=INFO
TF_ACC=1 go test ./... -v -parallel 20 -cover -short

In this original script, we run it when current directory is the root of repo. but it doesn't work for the last line of command go test because the current directory should be in provider/. So I add a line of cd command before the go test command line

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SkollRyu <sixmilk0128@gmail.com>
@prudhvigodithi
Copy link
Member

Thanks @SkollRyu can you also elaborate what does each step do for testing, so this way it would be easy for a new contributor to understand how the testing works.
Example like

Step 1: What its doing, purpose of this step

<command_used>

Step 2: What its doing, purpose of this step

<command_used>

Signed-off-by: SkollRyu <sixmilk0128@gmail.com>
@SkollRyu
Copy link
Author

SkollRyu commented Nov 9, 2023

Thanks for your suggestion. @prudhvigodithi I have added line by line explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📦 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants