Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serverless authentication not working #180

Merged

Conversation

rblcoder
Copy link
Collaborator

Description

Authentication for serverless has stopped working

Issues Resolved

Issue #179

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>
Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>
Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>
Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>
@rblcoder
Copy link
Collaborator Author

@prudhvigodithi Have tested with both these provider configurations with AWS OpenSearch Serverless

provider "opensearch" {
  url = "url"
  healthcheck        = "false"
  aws_profile = "profilename"
  aws_assume_role_arn = "rolearn"
  aws_assume_role_external_id = "externalid"
  aws_region          = "region"
  version_ping_timeout = "10"

}

and

provider "opensearch" {
  url = "url"
  healthcheck        = "false"
  aws_region          = "region"
  aws_access_key = "access key"
  aws_secret_key = "secret"
  version_ping_timeout = "10"

}

@prudhvigodithi
Copy link
Member

Had an offline discussion with @rblcoder and this code works, but however we should remove the osVersion info.Version.Number usages across the code as with branching and release of the terraform provider there is a compatibility matrix that will handle the right OpenSearch versions.
https://github.com/opensearch-project/terraform-provider-opensearch/blob/main/COMPATIBILITY.md
@bbarani

@prudhvigodithi prudhvigodithi merged commit 332430d into opensearch-project:main Apr 11, 2024
5 checks passed
PhilippReinke pushed a commit to PhilippReinke/terraform-provider-opensearch that referenced this pull request Apr 23, 2024
* Fix serverless authentication not working

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>

* Fix code formatting

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>

* Fix failing test

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>

* Add the code change for token back to the code

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>

---------

Signed-off-by: Rupa Lahiri <rupacoach@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants