Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #596 :Check for SFC virtual system list , before binding. Need… #599

Merged

Conversation

karimull
Copy link
Contributor

@karimull karimull commented Nov 2, 2017

… to have atleast one virtual system chained to sfc to bind

@arvindn05
Copy link
Member

@karimull please fix the build

…, before binding. Need to have atleast one virtual system chained to sfc to bind
@karimull karimull force-pushed the km-sfc-binding-master branch from e29ccd6 to 0a66d19 Compare November 6, 2017 20:47
@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #599 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #599      +/-   ##
============================================
- Coverage     25.95%   25.92%   -0.03%     
+ Complexity     1607     1605       -2     
============================================
  Files           501      501              
  Lines         20270    20273       +3     
  Branches       2393     2394       +1     
============================================
- Hits           5261     5256       -5     
- Misses        14615    14622       +7     
- Partials        394      395       +1
Impacted Files Coverage Δ Complexity Δ
...ervice/securitygroup/BindSecurityGroupService.java 79.7% <100%> (+0.3%) 49 <0> (+1) ⬆️
...c/main/java/org/osc/core/broker/job/JobEngine.java 56.39% <0%> (-3.01%) 18% <0%> (-1%)
...ver/src/main/java/org/osc/core/broker/job/Job.java 68.97% <0%> (-1.21%) 70% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4040072...0a66d19. Read the comment docs.

@arvindn05 arvindn05 merged commit db445e7 into opensecuritycontroller:master Nov 9, 2017
pravinrajr9 pushed a commit to pravinrajr9/osc-core that referenced this pull request Jan 8, 2018
…, before binding. Need to have atleast one virtual system chained to sfc to bind (opensecuritycontroller#599)
pravinrajr9 pushed a commit to pravinrajr9/osc-core that referenced this pull request Jan 10, 2018
…, before binding. Need to have atleast one virtual system chained to sfc to bind (opensecuritycontroller#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants