Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schema extensible and flexible #61

Closed
wants to merge 1 commit into from
Closed

Make schema extensible and flexible #61

wants to merge 1 commit into from

Conversation

leonwanghui
Copy link
Collaborator

For broker implementation of some service providers, they have enhanced some features by adding some additional fields in the schema. But currently validateJSONSchema method doesn't work because the definition of schema is fixed, so this patch is proposed to make schema more flexible so that service providers can implement some advanced features at the same time passing validation check.

@leonwanghui leonwanghui self-assigned this Nov 19, 2018
@cfdreddbot
Copy link

✅ Hey leonwanghui! The commit authors and yourself have already signed the CLA.

Copy link
Collaborator

@zhongyi-zhang zhongyi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@norshtein
Copy link
Collaborator

Copy link
Collaborator

@norshtein norshtein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@leonwanghui
Copy link
Collaborator Author

Thanks, will close it for now

@leonwanghui leonwanghui deleted the validate-schema branch November 20, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants