Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed case Plans #422

Closed
duglin opened this issue Jan 19, 2018 · 3 comments
Closed

Mixed case Plans #422

duglin opened this issue Jan 19, 2018 · 3 comments
Assignees

Comments

@duglin
Copy link
Contributor

duglin commented Jan 19, 2018

Right now the spec requires that plan names be all lowercase letters, however CF allows mixed-case letters. While we could look at this as bug in CF, since CF is the baseline implementation on which the spec is based (and we don't want to break existing brokers), I'm wondering if we need to loosen the language in the spec or ask CF to be spec compliant. I'm leaning towards changing the spec.

@duglin
Copy link
Contributor Author

duglin commented Jan 19, 2018

@mattmcneeney @zrob can you guys confirm that CF allows uppercase letters in Plan names?

@duglin duglin self-assigned this Jan 23, 2018
@duglin
Copy link
Contributor Author

duglin commented Jan 23, 2018

on today's call we tentatively agreed to change the spec to allow uppercase letters. PR coming soon.

@mattmcneeney
Copy link
Contributor

mattmcneeney commented Jan 23, 2018

CF allows both plan names and service names to have mixed case, so it would be great to update the spec. to loosen the requirements on both of these fields.

Interesting side note: When checking for unique service names and broker registration time, CF doesn't allow for two services to be registered regardless of case, i.e. "test" and "TEST". But it is possible to register a service called "MyService".

cc @duglin @zrob

duglin pushed a commit to duglin/servicebroker that referenced this issue Jan 30, 2018
Closes openservicebrokerapi#422

Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin pushed a commit to duglin/servicebroker that referenced this issue Jan 30, 2018
Closes openservicebrokerapi#422

Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin pushed a commit to duglin/servicebroker that referenced this issue Jan 30, 2018
Closes openservicebrokerapi#422

Signed-off-by: Doug Davis <dug@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants