-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add K8S and CF annotations to context object and CF bind resource #658
Merged
mattmcneeney
merged 7 commits into
openservicebrokerapi:master
from
orange-cloudfoundry:annotations
Aug 16, 2019
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d9f007
Add K8S and CF annotations to context object and CF bind resource
gberche-orange d4d072f
Add K8S and CF annotations to context object and CF bind resource
gberche-orange b93d59b
Add K8S and CF annotations to context object and CF bind resource
gberche-orange 5362f2f
Add K8S and CF annotations to context object and CF bind resource
gberche-orange 22227eb
Add K8S and CF annotations to context object and CF bind resource
gberche-orange 12b46c7
Add K8S and CF annotations to context object and CF bind resource
gberche-orange 80268a5
Add K8S and CF annotations to context object and CF bind resource
gberche-orange File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gberche-orange In the OSBAPI call we’ve realised that CF won’t have the prefixes here.
Is there expectation that the annotation object will always need such prefixes?, or is it only for K8S example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waterlink
I was hoping that the CF CAPI team would handle cloudfoundry/cloud_controller_ng#1335 bringing planned Cf/K8S consistency and that prefixes could be used to filter out private annotation keys as mentionned in #654 (comment) in a consistent way between CF and K8S:
I'm still waiting for CF CAPI response on this. The CF SAPI team could consider other alternative options for filtering private annotations though, and we could relax the CF examples in OSB API PR