Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Adds retry documentation and demo #369

Merged
merged 7 commits into from
May 26, 2022
Merged

Adds retry documentation and demo #369

merged 7 commits into from
May 26, 2022

Conversation

shalier
Copy link
Contributor

@shalier shalier commented May 13, 2022 •
edited
Loading

Adds documentation and demo for retry policy and fixes typo
resolves #318

@shalier shalier requested review from a team as code owners May 13, 2022 21:31
@shalier
Adds retry documentation and demo
34459c8 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@netlify
Copy link

netlify bot commented May 13, 2022

✅ Deploy Preview for osm-docs ready!

Name Link
🔨 Latest commit 28c3ee4
🔍 Latest deploy log https://app.netlify.com/sites/osm-docs/deploys/627ece2642e076000ad893b9
😎 Deploy Preview https://deploy-preview-369--osm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shalier shalier added the do-not-merge/hold Do not merge the PR label May 13, 2022
@netlify
Copy link

netlify bot commented May 13, 2022 •
edited
Loading

✅ Deploy Preview for osm-docs ready!

Name Link
🔨 Latest commit 86f6a22
🔍 Latest deploy log https://app.netlify.com/sites/osm-docs/deploys/628ea16f0293b20008d3ffaf
😎 Deploy Preview https://deploy-preview-369--osm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shalier
Copy link
Contributor Author

shalier commented May 13, 2022

In OSM v1.1.1 the Prometheus config does not contain the envoy retry metrics. Hold merge until the config has the metrics, because the demo relies on them

nojnhuh
nojnhuh suggested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just left a few comments for small stuff.

In OSM v1.1.1 the Prometheus config does not contain the envoy retry metrics. Hold merge until the config has the metrics, because the demo relies on them

If the metrics are already included in main then that shouldn't block this PR since the live version of the docs are built from the release branch so the main branch here can stay in sync with the main branch of the code repo.

content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/guides/traffic_management/retry_policy.md Outdated Show resolved Hide resolved
content/docs/guides/traffic_management/retry_policy.md Outdated Show resolved Hide resolved
content/docs/guides/traffic_management/retry_policy.md Outdated Show resolved Hide resolved
content/docs/guides/traffic_management/retry_policy.md Outdated Show resolved Hide resolved
@shalier shalier removed the do-not-merge/hold Do not merge the PR label May 24, 2022
shalier added 2 commits May 24, 2022 14:42
@shalier
updated guide w/ backoff explanation + updated demo w/ description an…
2e5ef33 
…d simplified commands

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier
removes use of prometheus
e69c142 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier
don't need to enable metrics on httpbin ns
7989ecc 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
shashankram
shashankram reviewed May 24, 2022
View reviewed changes
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc @shalier

content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
@shalier shalier force-pushed the retryDoc branch 5 times, most recently from d6ce5d6 to 6930276 Compare May 24, 2022 22:08
@shalier
fix format
d23f1fb 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier shalier force-pushed the retryDoc branch 2 times, most recently from 134414d to 7b27464 Compare May 24, 2022 22:24
@shalier
Change demo description
09c4afc 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier shalier requested a review from nojnhuh May 24, 2022 22:27
nojnhuh
nojnhuh reviewed May 25, 2022
View reviewed changes
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
content/docs/demos/retry_policy.md Show resolved Hide resolved
content/docs/demos/retry_policy.md Outdated Show resolved Hide resolved
@shalier
fixes indentation of yaml, adds retry to curl ns
86f6a22 
Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@shalier shalier requested a review from nojnhuh May 25, 2022 21:37
@nojnhuh nojnhuh merged commit e69d42e into openservicemesh:main May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shashankram shashankram shashankram approved these changes

@nojnhuh nojnhuh nojnhuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a demo for the Retry feature
3 participants
@shalier @nojnhuh @shashankram