Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Commit

Permalink
tests/e2e: fix default expectations in Helm install test
Browse files Browse the repository at this point in the history
After ea1d39a and dcfe26e, tracing defaults to false and
the tracing config is only set when tracing is enabled.
This change updates the Helm install test to reflect this.

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
  • Loading branch information
shashankram committed Feb 1, 2021
1 parent 885b653 commit a6f634d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions tests/e2e/e2e_helm_install_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var _ = OSMDescribe("Test osm control plane installation with Helm",
Bucket: 1,
},
func() {
Context("Using default values", func() {
Context("Helm install using default values", func() {
It("installs osm control plane successfully", func() {
if Td.InstType == NoInstall {
Skip("Test is not going through InstallOSM, hence cannot be automatically skipped with NoInstall (#1908)")
Expand All @@ -34,10 +34,7 @@ var _ = OSMDescribe("Test osm control plane installation with Helm",
Expect(configmap.Data["envoy_log_level"]).Should(Equal("error"))
Expect(configmap.Data["enable_debug_server"]).Should(Equal("false"))
Expect(configmap.Data["prometheus_scraping"]).Should(Equal("true"))
Expect(configmap.Data["tracing_enable"]).Should(Equal("true"))
Expect(configmap.Data["tracing_address"]).Should(Equal("jaeger.osm-system.svc.cluster.local"))
Expect(configmap.Data["tracing_port"]).Should(Equal("9411"))
Expect(configmap.Data["tracing_endpoint"]).Should(Equal("/api/v2/spans"))
Expect(configmap.Data["tracing_enable"]).Should(Equal("false"))
Expect(configmap.Data["use_https_ingress"]).Should(Equal("false"))
Expect(configmap.Data["service_cert_validity_duration"]).Should(Equal("24h"))

Expand Down

0 comments on commit a6f634d

Please sign in to comment.