Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Commit

Permalink
fix(make): update e2e kind cluster flag
Browse files Browse the repository at this point in the history
This flag changed from `-kindCluster` to `-installType=KindCluster` but
the Makefile wasn't updated. This change adds the fix so `make test-e2e`
doesn't throw an error for the unknown flag.

Signed-off-by: Jon Huhn <johuhn@microsoft.com>
  • Loading branch information
nojnhuh committed Jan 26, 2021
1 parent 2316bdc commit bfdfc0f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ BUILD_GITCOMMIT_VAR := github.com/openservicemesh/osm/pkg/version.GitCommit
LDFLAGS ?= "-X $(BUILD_DATE_VAR)=$(BUILD_DATE) -X $(BUILD_VERSION_VAR)=$(VERSION) -X $(BUILD_GITCOMMIT_VAR)=$(GIT_SHA) -X main.chartTGZSource=$$(cat -) -s -w"

# These two values are combined and passed to go test
E2E_FLAGS ?= -kindCluster
E2E_FLAGS ?= -installType=KindCluster
E2E_FLAGS_DEFAULT := -test.v -ginkgo.v -ginkgo.progress -ctrRegistry $(CTR_REGISTRY) -osmImageTag $(CTR_TAG)

check-env:
Expand Down

0 comments on commit bfdfc0f

Please sign in to comment.