Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Commit d3e9906

Browse files
authored
Fix spacing issues on values.yaml file (#1812)
Helm Chart ConfigMap is using `OpenServiceMesh.serviceCertValidityDuration` Current default values are using `OpenServiceMesh.certmanager.serviceCertValidityDuration` Looking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the [osm cli](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/cmd/cli/install.go#L210) because it is passing the value itself. [Configmap Template](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/charts/osm/templates/osm-configmap.yaml#L21): ``` service_cert_validity_duration: {{ .Values.OpenServiceMesh.serviceCertValidityDuration | quote }} ```
1 parent 1291e4b commit d3e9906

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

charts/osm/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ OpenServiceMesh:
2323
issuerName: osm-ca
2424
issuerKind: Issuer
2525
issuerGroup: cert-manager
26-
serviceCertValidityDuration: 24h
26+
serviceCertValidityDuration: 24h
2727
caBundleSecretName: osm-ca-bundle
2828
grafana:
2929
port: 3000

0 commit comments

Comments
 (0)