Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Commit

Permalink
Fix spacing issues on values.yaml file (#1812)
Browse files Browse the repository at this point in the history
Helm Chart ConfigMap is using `OpenServiceMesh.serviceCertValidityDuration`
Current default values are using `OpenServiceMesh.certmanager.serviceCertValidityDuration`
Looking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the [osm cli](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/cmd/cli/install.go#L210) because it is passing the value itself.
[Configmap Template](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/charts/osm/templates/osm-configmap.yaml#L21):
```
service_cert_validity_duration: {{ .Values.OpenServiceMesh.serviceCertValidityDuration | quote }}
```
  • Loading branch information
EStork09 authored Oct 12, 2020
1 parent 1291e4b commit d3e9906
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/osm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ OpenServiceMesh:
issuerName: osm-ca
issuerKind: Issuer
issuerGroup: cert-manager
serviceCertValidityDuration: 24h
serviceCertValidityDuration: 24h
caBundleSecretName: osm-ca-bundle
grafana:
port: 3000
Expand Down

0 comments on commit d3e9906

Please sign in to comment.