This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Fix spacing issues on values.yaml file #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm Chart ConfigMap is using `OpenServiceMesh.serviceCertValidityDuration` Current default values are using `OpenServiceMesh.certmanager.serviceCertValidityDuration` Looking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the [osm cli](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/cmd/cli/install.go#L210) because it is passing the value itself. [Configmap Template](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/charts/osm/templates/osm-configmap.yaml#L21): ``` service_cert_validity_duration: {{ .Values.OpenServiceMesh.serviceCertValidityDuration | quote }} ```
Codecov Report
@@ Coverage Diff @@
## main #1812 +/- ##
==========================================
- Coverage 59.20% 58.97% -0.24%
==========================================
Files 125 125
Lines 5170 5170
==========================================
- Hits 3061 3049 -12
- Misses 2106 2118 +12
Partials 3 3
Continue to review full report at Codecov.
|
michelleN
approved these changes
Oct 12, 2020
nojnhuh
approved these changes
Oct 12, 2020
eduser25
pushed a commit
to eduser25/osm
that referenced
this pull request
Oct 14, 2020
Helm Chart ConfigMap is using `OpenServiceMesh.serviceCertValidityDuration` Current default values are using `OpenServiceMesh.certmanager.serviceCertValidityDuration` Looking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the [osm cli](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/cmd/cli/install.go#L210) because it is passing the value itself. [Configmap Template](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/charts/osm/templates/osm-configmap.yaml#L21): ``` service_cert_validity_duration: {{ .Values.OpenServiceMesh.serviceCertValidityDuration | quote }} ```
draychev
pushed a commit
to draychev/osm
that referenced
this pull request
Oct 28, 2020
Helm Chart ConfigMap is using `OpenServiceMesh.serviceCertValidityDuration` Current default values are using `OpenServiceMesh.certmanager.serviceCertValidityDuration` Looking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the [osm cli](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/cmd/cli/install.go#L210) because it is passing the value itself. [Configmap Template](https://github.com/openservicemesh/osm/blob/11e7e5eae48790bef3c7e3a51f7d1e6206d45a0d/charts/osm/templates/osm-configmap.yaml#L21): ``` service_cert_validity_duration: {{ .Values.OpenServiceMesh.serviceCertValidityDuration | quote }} ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm Chart ConfigMap is using
OpenServiceMesh.serviceCertValidityDurationCurrent default values are using
OpenServiceMesh.certmanager.serviceCertValidityDurationLooking at the other places this is referenced I believe this should be updated to be outside of certmanager. It looks like it doesn't happen in the osm cli because it is passing the value itself.
Configmap Template:
Description:
Updating default values file on the helm charts to match installer values.
Affected area:
Please answer the following questions with yes/no.
No