Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

GetServiceForServiceAccount should list all associated services #1550

Closed
ksubrmnn opened this issue Aug 17, 2020 · 1 comment · Fixed by #1553 or #1586
Closed

GetServiceForServiceAccount should list all associated services #1550

ksubrmnn opened this issue Aug 17, 2020 · 1 comment · Fixed by #1553 or #1586
Assignees
Milestone

Comments

@ksubrmnn
Copy link
Contributor

Please describe the Improvement and/or Feature Request

Change GetServiceForServiceAccount to so it returns a slice of MeshServices instead of a single MeshService reference. (The function itself contains a check for > 1 services and returns an error – remove)

This will removes the 1-1 mapping in OSM for Services to Service Accounts and more closely follows how ServiceAccounts map 1-1 with PodSpecs which can map to multiple services.

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [X]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Project Release [ ]

Possible use cases

This change will begin the work of programming Envoy for service accounts and not services. This work will also eventually pave the way for finding the root service of backend services with and without TrafficSplit

@ksubrmnn
Copy link
Contributor Author

The initial PR #1553 refactored the method signature and updated references to only use the first service returned. The following lines need to be revisited in a follow up PR

Routes 245

Routes 258

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.