This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(mesh catalog): Return list of services for a given service account #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksubrmnn
commented
Aug 17, 2020
| func (mc *MeshCatalog) GetServiceForServiceAccount(sa service.K8sServiceAccount) (service.MeshService, error) { | ||
| // GetServicesForServiceAccount returns a list of services corresponding to a service account | ||
| func (mc *MeshCatalog) GetServicesForServiceAccount(sa service.K8sServiceAccount) ([]service.MeshService, error) { | ||
| services := []service.MeshService{} | ||
| for _, provider := range mc.endpointsProviders { | ||
| // TODO (#88) : remove this provider check once we have figured out the service account story for azure vms | ||
| if provider.GetID() != constants.AzureProviderName { | ||
| log.Trace().Msgf("[%s] Looking for Services for Name=%s", provider.GetID(), sa) | ||
| service, err := provider.GetServiceForServiceAccount(sa) |
There was a problem hiding this comment.
will refactor provider functions (if needed) when Shashank merges his change
shashankram
approved these changes
Aug 17, 2020
| if destErr != nil { | ||
| log.Error().Msgf("TrafficTarget %s/%s could not get destination services for service account %s", trafficTargets.Namespace, trafficTargets.Name, dstNamespacedServiceAcc.String()) | ||
| return nil, destErr | ||
| } | ||
| destService := destServiceList[0] |
There was a problem hiding this comment.
would be good to create an issue and reference it wherever these assumptions are being made.
There was a problem hiding this comment.
Updated issue #1550
| func (mc *MeshCatalog) GetServiceForServiceAccount(sa service.K8sServiceAccount) (service.MeshService, error) { | ||
| // GetServicesForServiceAccount returns a list of services corresponding to a service account | ||
| func (mc *MeshCatalog) GetServicesForServiceAccount(sa service.K8sServiceAccount) ([]service.MeshService, error) { | ||
| services := []service.MeshService{} | ||
| for _, provider := range mc.endpointsProviders { | ||
| // TODO (#88) : remove this provider check once we have figured out the service account story for azure vms | ||
| if provider.GetID() != constants.AzureProviderName { | ||
| log.Trace().Msgf("[%s] Looking for Services for Name=%s", provider.GetID(), sa) | ||
| service, err := provider.GetServiceForServiceAccount(sa) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the motivation for this PR and provide enough
information so that others can review it.
Returns a list of services instead of a single service for a given service account
Please mark with X for applicable areas.
Please answer the following questions with yes/no.
No