Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test: cmd/cli/* cobra flags #3417

Closed
Tracked by #1489
SanyaKochhar opened this issue May 25, 2021 · 0 comments · Fixed by #3727
Closed
Tracked by #1489

test: cmd/cli/* cobra flags #3417

SanyaKochhar opened this issue May 25, 2021 · 0 comments · Fixed by #3727
Assignees
@jaellio
Labels
area/tests Related to tests good first issue Good for newcomers kind/research-required Requires further research to make progress size/XS 1 day
Milestone
v0.10.0

Comments

@SanyaKochhar
Copy link
Contributor

SanyaKochhar commented May 25, 2021 •
edited
Loading

All commands that have cobra flags show up as not having test coverage for those lines of code. It would help to investigate whether this is testable and, if so, test flags for the following:

  • cmd/cli/install.go
  • cmd/cli/mesh_upgrade.go
  • cmd/cli/uninstall.go
  • cmd/cli/proxy_get.go
  • cmd/cli/dashboard.go
  • cmd/cli/namespace_add.go
  • cmd/cli/mesh_list.go
  • cmd/cli/metrics_disable.go
  • cmd/cli/metrics_enable.go
  • cmd/cli/namespace_list.go
  • cmd/cli/namespace_remove.go
  • cmd/cli/osm.go:

If it is not possible, please comment why and feel free to close this issue.

For example:
image

image

image
@SanyaKochhar SanyaKochhar added good first issue Good for newcomers size/XS 1 day kind/research-required Requires further research to make progress area/tests Related to tests labels May 25, 2021
@SanyaKochhar SanyaKochhar mentioned this issue May 25, 2021
Closed
@draychev draychev added this to the v0.10.0 milestone May 25, 2021
@jaellio jaellio self-assigned this Jun 29, 2021
@draychev draychev mentioned this issue Jun 30, 2021
Closed
15 tasks
shashankram added a commit to shashankram/osm that referenced this issue Jul 6, 2021
@shashankram
cli/test: add unit test for command initialization
60f1a79 
Adds a generic unit test for command initialization.

Resolves openservicemesh#3417

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
@shashankram shashankram mentioned this issue Jul 6, 2021
Merged
jaellio pushed a commit to jaellio/osm that referenced this issue Jul 12, 2021
@shashankram @jaellio
cli/test: add unit test for command initialization
550b3be 
Adds a generic unit test for command initialization.

Resolves openservicemesh#3417

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
shashankram added a commit to shashankram/osm that referenced this issue Jul 15, 2021
@shashankram
cli/test: add unit test for command initialization
bee6476 
Adds a generic unit test for command initialization.

Resolves openservicemesh#3417

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaellio jaellio

Labels
area/tests Related to tests good first issue Good for newcomers kind/research-required Requires further research to make progress size/XS 1 day
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

cli/test: add unit test for command initialization shashankram/osm
3 participants
@SanyaKochhar @draychev @jaellio