This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(ci): Upload test coverage to codecov #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleN
approved these changes
Aug 5, 2020
bridgetkromhout
approved these changes
Aug 5, 2020
| @@ -161,6 +161,9 @@ jobs: | |||
| go-version: 1.14 | |||
| - name: Test | |||
| run: make go-test-coverage | |||
| - name: Upload Coverage | |||
| if: ${{ success() }} | |||
| run: bash <(curl -s https://codecov.io/bash) | |||
|
@nojnhuh what does that line do? |
|
This is how they describe it in their docs: https://docs.codecov.io/docs/about-the-codecov-bash-uploader Looks like there may be a native GitHub Actions solution. I'll look into that. |
|
Looks like their GitHub action does basically the same thing. https://github.com/codecov/codecov-action/blob/master/index.js#L127 That looks easier to customize though, so we can start using that once we need it. By itself it doesn't look like we gain anything over the plain script. |
|
ah so we've already exported the CODECOV token? |
|
That's only required for private repos. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.