Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(demo/deploy-bookbuyer): add sleep duration env variable to bookbuyer deployment #1442

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Aug 6, 2020

In response to #1221. Add CI_SLEEP_BETWEEN_REQUESTS_SECONDS with default values to deploy_bookbuyer.sh, so that the corresponding value in sleepDurationBetweenRequestsSecondsStr is changed.

@Jont828 Jont828 requested a review from a team as a code owner August 6, 2020 21:03
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document this in .env.example similar to CI_MAX_ITERATIONS_THRESHOLD.

Copy link
Contributor

@ksubrmnn ksubrmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes to .env.example per Shashank's comment

@Jont828 Jont828 force-pushed the sleep-duration-bug branch from edffc20 to 292f31c Compare August 11, 2020 16:45
@Jont828 Jont828 requested a review from ksubrmnn August 11, 2020 17:15
@Jont828 Jont828 merged commit 67476c3 into openservicemesh:main Aug 11, 2020
@Jont828 Jont828 deleted the sleep-duration-bug branch August 11, 2020 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants