This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
demo: disable egress by default #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the install command has egress disabled for default for the purpose of simplifying manual demos, disable egress requests in the demo apps as well. An `ENABLE_EGRESS` env variable is used to turn on/off egress in the demo and in the client demo apps.
eduser25
reviewed
Aug 8, 2020
eduser25
approved these changes
Aug 8, 2020
ksubrmnn
approved these changes
Aug 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the install command has egress disabled for default
for the purpose of simplifying manual demos, disable egress
requests in the demo apps as well. An
ENABLE_EGRESSenvvariable is used to turn on/off egress in the demo and
in the client demo apps.
Please describe the motivation for this PR and provide enough
information so that others can review it.
Please mark with X for applicable areas.
Please answer the following questions with yes/no.
No