zipkin : Updating configmap for zipkin

[snehachhabria]

This PR adds updates the configmap to show zipkin related values only when zipkin tracking is enabled in OSM

Please mark with X for applicable areas.

• New Functionality [ ]
• Documentation [ ]
• Install [X]
• Control Plane [ ]
• CLI Tool [ ]
• Certificate Management [ ]
• Networking [ ]
• Metrics [ ]
• SMI Policy [ ]
• Security [ ]
• Tests / CI System [ ]
• Other [ ]

Please answer the following questions with yes/no.

• Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? No

[michelleN]

hey @snehachhabria - why are we updating this post-deploy. The service/port info is already available in the chart values file. Why is that not being passed in to osm-controller at deploy time? Could you explain a bit more about why the changes to pkg/configuration/client.go are needed?

[shashankram]

hey @snehachhabria - why are we updating this post-deploy. The service/port info is already available in the chart values file. Why is that not being passed in to osm-controller at deploy time? Could you explain a bit more about why the changes to pkg/configuration/client.go are needed?

Based on my chat with Sneha, the changes to pkg/configuration/client.go are not needed.

[snehachhabria]

hey @snehachhabria - why are we updating this post-deploy. The service/port info is already available in the chart values file. Why is that not being passed in to osm-controller at deploy time? Could you explain a bit more about why the changes to pkg/configuration/client.go are needed?

@michelleN I have reverted the changes in pkg/configuration/client.go, PTAL and let me know if you have any other questions. The changes I am making are related to zipkin and has nothing to do with osm-controller