Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Updating assignment of optional values in osm-config ConfigMap #1547

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Updating assignment of optional values in osm-config ConfigMap #1547

merged 2 commits into from
Aug 17, 2020

Conversation

snehachhabria
Copy link
Contributor

This PR updates the way the optional values in the osm-config configmap are assigned. It fixes #1543

Please mark with X for applicable areas.

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests / CI System [ ]
  • Other [X]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? No

@snehachhabria snehachhabria requested a review from a team as a code owner August 17, 2020 19:01
@snehachhabria snehachhabria merged commit 38176ae into openservicemesh:main Aug 17, 2020
@snehachhabria snehachhabria deleted the fixerrorlogconfigmap branch August 17, 2020 23:57
shashankram added a commit to shashankram/osm that referenced this pull request Aug 18, 2020
@shashankram
configurator: remove error field from debug log
0b5733b 
Debug logs shouldn't log errors, remove error tag to prevent the
logger from logging unnecessary error fields in the logs. This
log statement is intended to be Debug level, as changed by PR openservicemesh#1547.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
@shashankram shashankram mentioned this pull request Aug 18, 2020
Merged
shashankram added a commit to shashankram/osm that referenced this pull request Aug 18, 2020
@shashankram
configurator: remove error field from debug log
f8c62a6 
Debug logs shouldn't log errors, remove error tag to prevent the
logger from logging unnecessary error fields in the logs. This
log statement is intended to be Debug level, as changed by PR openservicemesh#1547.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
shashankram added a commit to shashankram/osm that referenced this pull request Aug 18, 2020
@shashankram
configurator: remove error field from debug log
c789647 
Debug logs shouldn't log errors, remove error tag to prevent the
logger from logging unnecessary error fields in the logs. This
log statement is intended to be Debug level, as changed by PR openservicemesh#1547.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
shashankram added a commit to shashankram/osm that referenced this pull request Aug 18, 2020
@shashankram
configurator: remove error field from debug log
60453be 
Debug logs shouldn't log errors, remove error tag to prevent the
logger from logging unnecessary error fields in the logs. This
log statement is intended to be Debug level, as changed by PR openservicemesh#1547.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
shashankram added a commit that referenced this pull request Aug 18, 2020
@shashankram
configurator: remove error field from debug log (#1585)
05496d1 
Debug logs shouldn't log errors, remove error tag to prevent the
logger from logging unnecessary error fields in the logs. This
log statement is intended to be Debug level, as changed by PR #1547.

Signed-off-by: Shashank Ram <shashank08@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shashankram shashankram shashankram approved these changes

@eduser25 eduser25 eduser25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error logs for optional osm-config ConfigMap options
3 participants
@snehachhabria @eduser25 @shashankram