This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(envoy): Return list of services in GetServiceFromEnvoyCertificate #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksubrmnn
force-pushed
the
services_from_cert
branch
from
3d24216 to
b154f7f
Compare
shashankram
suggested changes
Aug 18, 2020
ksubrmnn
force-pushed
the
services_from_cert
branch
2 times, most recently
from
bcf6ec3 to
dc81a3d
Compare
ksubrmnn
force-pushed
the
services_from_cert
branch
from
dc81a3d to
b9d32c7
Compare
snehachhabria
approved these changes
Aug 18, 2020
Comment on lines
+45
to
+48
| meshService := service.MeshService{ | ||
| Namespace: cnMeta.Namespace, | ||
| Name: svc.Name, | ||
| } |
There was a problem hiding this comment.
Just a thought, it might be a good idea to abstract the conversion of a service to meshService in a utils function and they use it everywhere. WDYT ?
There was a problem hiding this comment.
From kubernetes service to meshService? I think that's a good idea. Can you make an issue and tag it as "good first issue"?
There was a problem hiding this comment.
There is a helper for converting K8s service to MeshService in catalog/routes.go: k8sSvcToMeshSvc
There was a problem hiding this comment.
@ksubrmnn please could we use k8sSvcToMeshSvc wherever possible
shashankram
approved these changes
Aug 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the motivation for this PR and provide enough
information so that others can review it.
Return a list of services for an envoy certificate instead of just the first one
Please mark with X for applicable areas.
Please answer the following questions with yes/no.
No