This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
catalog: Simplify GetServicesForServiceAccount() #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleN
previously approved these changes
Aug 18, 2020
shashankram
reviewed
Aug 18, 2020
|
Merged from main, removed one log message (seems redundand), rewrote the log messages for clarity. |
snehachhabria
approved these changes
Aug 19, 2020
eduser25
reviewed
Aug 19, 2020
| } else { | ||
| log.Trace().Msgf("[%s] Found services %v for Name=%s", provider.GetID(), services, sa) | ||
| services = append(services, providerServices...) | ||
| if provider.GetID() == constants.AzureProviderName { |
There was a problem hiding this comment.
Should we just remove AzureProvider from endpointProviders for the time being instead?
I think it'll look cleaner overall, and once we retake the VM endpoints effort we can always add it back
edit: I'm assuming by this check, this is not currently used by anything at all
There was a problem hiding this comment.
@eduser25 - we could inded remove the Azure Endpoint Provider stuff until we have Identity + VM representation in SMI.
ksubrmnn
approved these changes
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
continuein theconstants.AzureProviderNamecheckserviceconflicts with imported package - renamed tosvcNo functional code changes in this PR.
Please mark with X for applicable areas.
Please answer the following questions with yes/no.