This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Rename Route type to HTTPRoute where applicable #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code refers to an HTTPRoute as a Route in a traffic target policy. Rename this to HTTPRoute to be explicit. In the future, a route for different traffic types will be supported, ex. TCPRoute. Signed-off-by: Shashank Ram <shashank08@gmail.com>
shashankram
force-pushed
the
http-route
branch
from
7610b1a to
cd3ee11
Compare
shashankram
changed the title
eduser25
approved these changes
Aug 24, 2020
snehachhabria
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code refers to an HTTPRoute as a Route in a traffic target
policy. Rename this to HTTPRoute to be explicit. In the future, a route
for different traffic types will be supported, ex. TCPRoute.
This also helps disambiguate the HTTP route type in the traffic target from
the XDS Route type in Envoy.
Please answer the following questions with yes/no.
No