Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ref(cmd/cli): isolate install validation logic #1621

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

michelleN
Copy link
Contributor

@michelleN michelleN commented Aug 25, 2020

I was reviewing this code with the new folks on the team and realized it could use a little re-organization to make it easier to understand what is happening.

  • No functional code changes
  • Adds comments in line

Please mark with X for applicable areas.

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [X]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests / CI System [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? No

@michelleN michelleN requested a review from a team as a code owner August 25, 2020 22:29
@michelleN michelleN force-pushed the install branch 2 times, most recently from a3d3527 to 57e32e9 Compare August 26, 2020 01:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #1621 into main will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   55.05%   55.06%           
=======================================
  Files         117      117           
  Lines        4922     4949   +27     
=======================================
+ Hits         2710     2725   +15     
- Misses       2210     2222   +12     
  Partials        2        2           
Impacted Files Coverage Δ
cmd/cli/install.go 66.20% <87.50%> (+2.02%) ⬆️
...ertificate/providers/tresor/certificate_manager.go 65.34% <0.00%> (-11.89%) ⬇️
pkg/envoy/rds/response.go 26.86% <0.00%> (-0.41%) ⬇️
pkg/catalog/routes.go 81.60% <0.00%> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c55c40...2d30d72. Read the comment docs.

shashankram
shashankram previously approved these changes Aug 26, 2020
* Create validateOptions method for install
* Improve error handling
* Add comments in line
@michelleN michelleN merged commit d6f767d into openservicemesh:main Aug 27, 2020
@michelleN michelleN deleted the install branch August 27, 2020 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants