This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
osm-controller/test: compare cert for equality instead of its length #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test hardcodes the expected length for a certificate, compare the certificate content instead. An issue was seen when the Go version was updated, possibly resulting from a change in a lib used for generating the certs. This change removes the length check and directly compares the certificate. Resolves openservicemesh#1635 Signed-off-by: Shashank Ram <shashank08@gmail.com>
michelleN
approved these changes
Aug 27, 2020
draychev
approved these changes
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test hardcodes the expected length for a certificate, compare
the certificate content instead. An issue was seen when the Go
version was updated, possibly resulting from a change in a lib
used for generating the certs. This change removes the length
check and directly compares the certificate.
Resolves #1635
Signed-off-by: Shashank Ram shashank08@gmail.com
Please answer the following questions with yes/no.
No