This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
docs: add mocking info to unit testing guide #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves openservicemesh#1649 Signed-off-by: Shashank Ram <shashank08@gmail.com>
nojnhuh
approved these changes
Sep 4, 2020
| As an example, to create a mock client for the `Configurator` interface defined in the [configurator](/pkg/configurator) package: | ||
| ```bash | ||
| mockgen -destination=pkg/configurator/mock_client.go -package=configurator github.com/openservicemesh/osm/pkg/configurator Configurator | ||
| ``` |
There was a problem hiding this comment.
Could you either add to this PR or follow up with a change to include this package in tools.go at the root of the repo and update the instructions to use go run ... to invoke the generator? That way we can track the version we're using and there's no extra step required to get the mockgen binary.
There was a problem hiding this comment.
Will do in a follow-up.
eduser25
approved these changes
Sep 4, 2020
draychev
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1649
Signed-off-by: Shashank Ram shashank08@gmail.com
Please answer the following questions with yes/no.